wgroeneveld
/
jasmine-junit-runner
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #21 from jdobson/master 

Call RunNotifier's fireTestFinished() method for failed tests
This commit is contained in:
Wouter Groeneveld 2015-05-21 11:08:52 +02:00
parent 8d914f55bb 968df29e77
commit c74aac7548
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/main/java/be/klak/junit/jasmine/JasmineTestRunner.java
View File

@ -228,6 +228,7 @@ public class JasmineTestRunner extends Runner {
notifier.fireTestFinished(spec.getDescription()); notifier.fireTestFinished(spec.getDescription());
} else if (spec.isFailed(rhinoContext)) { } else if (spec.isFailed(rhinoContext)) {
notifier.fireTestFailure(spec.getJunitFailure(rhinoContext)); notifier.fireTestFailure(spec.getJunitFailure(rhinoContext));
notifier.fireTestFinished(spec.getDescription());
} else { } else {
throw new IllegalStateException("Unexpected spec status received: " + spec); throw new IllegalStateException("Unexpected spec status received: " + spec);
} }

2
src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java
View File

@ -32,6 +32,7 @@ public class JasmineFailingSpecsTest {
ArgumentCaptor<Description> descriptionCaptor = ArgumentCaptor.forClass(Description.class); ArgumentCaptor<Description> descriptionCaptor = ArgumentCaptor.forClass(Description.class);
verify(notifierMock).fireTestStarted(descriptionCaptor.capture()); verify(notifierMock).fireTestStarted(descriptionCaptor.capture());
verify(notifierMock).fireTestFailure(failureCaptor.capture()); verify(notifierMock).fireTestFailure(failureCaptor.capture());
verify(notifierMock).fireTestFinished(descriptionCaptor.capture());
verifyNoMoreInteractions(notifierMock); verifyNoMoreInteractions(notifierMock);
Failure failure = failureCaptor.getValue(); Failure failure = failureCaptor.getValue();
@ -50,6 +51,7 @@ public class JasmineFailingSpecsTest {
ArgumentCaptor<Description> descriptionCaptor = ArgumentCaptor.forClass(Description.class); ArgumentCaptor<Description> descriptionCaptor = ArgumentCaptor.forClass(Description.class);
verify(notifierMock).fireTestStarted(descriptionCaptor.capture()); verify(notifierMock).fireTestStarted(descriptionCaptor.capture());
verify(notifierMock).fireTestFailure(failureCaptor.capture()); verify(notifierMock).fireTestFailure(failureCaptor.capture());
verify(notifierMock).fireTestFinished(descriptionCaptor.capture());
verifyNoMoreInteractions(notifierMock); verifyNoMoreInteractions(notifierMock);
Failure failure = failureCaptor.getValue(); Failure failure = failureCaptor.getValue();