From 968df29e77d609ab87eff53b138efa1a80c8f699 Mon Sep 17 00:00:00 2001 From: James Dobson Date: Mon, 30 Mar 2015 16:59:55 +0100 Subject: [PATCH] Added a call to the RunNotifier's fireTestFinished() method after notifying it of a failed test. --- src/main/java/be/klak/junit/jasmine/JasmineTestRunner.java | 1 + .../java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/main/java/be/klak/junit/jasmine/JasmineTestRunner.java b/src/main/java/be/klak/junit/jasmine/JasmineTestRunner.java index 848d94c..ab46354 100644 --- a/src/main/java/be/klak/junit/jasmine/JasmineTestRunner.java +++ b/src/main/java/be/klak/junit/jasmine/JasmineTestRunner.java @@ -228,6 +228,7 @@ public class JasmineTestRunner extends Runner { notifier.fireTestFinished(spec.getDescription()); } else if (spec.isFailed(rhinoContext)) { notifier.fireTestFailure(spec.getJunitFailure(rhinoContext)); + notifier.fireTestFinished(spec.getDescription()); } else { throw new IllegalStateException("Unexpected spec status received: " + spec); } diff --git a/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java b/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java index 5a9a63a..bc137d1 100644 --- a/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java +++ b/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java @@ -32,6 +32,7 @@ public class JasmineFailingSpecsTest { ArgumentCaptor descriptionCaptor = ArgumentCaptor.forClass(Description.class); verify(notifierMock).fireTestStarted(descriptionCaptor.capture()); verify(notifierMock).fireTestFailure(failureCaptor.capture()); + verify(notifierMock).fireTestFinished(descriptionCaptor.capture()); verifyNoMoreInteractions(notifierMock); Failure failure = failureCaptor.getValue(); @@ -50,6 +51,7 @@ public class JasmineFailingSpecsTest { ArgumentCaptor descriptionCaptor = ArgumentCaptor.forClass(Description.class); verify(notifierMock).fireTestStarted(descriptionCaptor.capture()); verify(notifierMock).fireTestFailure(failureCaptor.capture()); + verify(notifierMock).fireTestFinished(descriptionCaptor.capture()); verifyNoMoreInteractions(notifierMock); Failure failure = failureCaptor.getValue();