From d261aad1fd3af89695c0574a6c690937c56c6f4e Mon Sep 17 00:00:00 2001 From: unknown Date: Thu, 29 Mar 2012 09:10:14 +0200 Subject: [PATCH 1/2] Test error message only on a substring as it can be translated in other languages than english and therefore fail --- .../java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java b/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java index 96f064b..460ace8 100755 --- a/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java +++ b/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java @@ -14,7 +14,6 @@ import org.mockito.Mock; import org.mockito.runners.MockitoJUnitRunner; import org.mozilla.javascript.EvaluatorException; -import be.klak.junit.jasmine.JasmineTestRunner; import be.klak.junit.jasmine.classes.JasmineTestRunnerExceptionInJSCode; import be.klak.junit.jasmine.classes.JasmineTestRunnerExceptionInSpec; import be.klak.junit.jasmine.classes.JasmineTestRunnerFailingSpec; @@ -58,7 +57,7 @@ public class JasmineFailingSpecsTest { assertThat(failure.getDescription()).isEqualTo(startedDescription); assertThat(failure.getDescription().getDisplayName()).isEqualTo("will always crash"); - assertThat(failure.getMessage()).isEqualTo("ReferenceError: \"OEIWANU\" is not defined. in src/test/javascript/specs/crashingSpec.js (line 3)"); + assertThat(failure.getMessage().substring(0,25)).isEqualTo("ReferenceError: \"OEIWANU\"");// is not defined. in src/test/javascript/specs/crashingSpec.js (line 3)"); } @Test(expected = EvaluatorException.class) From 76d106c95fbdd4484a2d95e631f7d88fb09fda59 Mon Sep 17 00:00:00 2001 From: unknown Date: Thu, 29 Mar 2012 10:37:00 +0200 Subject: [PATCH 2/2] Best test than the quick and dirty "substring" --- .../java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java b/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java index 460ace8..ed869bc 100755 --- a/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java +++ b/src/test/java/be/klak/junit/jasmine/JasmineFailingSpecsTest.java @@ -57,7 +57,7 @@ public class JasmineFailingSpecsTest { assertThat(failure.getDescription()).isEqualTo(startedDescription); assertThat(failure.getDescription().getDisplayName()).isEqualTo("will always crash"); - assertThat(failure.getMessage().substring(0,25)).isEqualTo("ReferenceError: \"OEIWANU\"");// is not defined. in src/test/javascript/specs/crashingSpec.js (line 3)"); + assertThat(failure.getMessage()).contains("ReferenceError: \"OEIWANU\""); } @Test(expected = EvaluatorException.class)