wgroeneveld
/
go-jamming
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Inclusive language update (allowlist/denylist). #4

Merged
wgroeneveld merged 1 commits from JonathanStreet/go-jamming:main into master 2023-03-03 16:18:02 +01:00
Conversation 1 Commits 1 Files Changed 20 +124 -124
JonathanStreet commented 2023-03-01 17:57:36 +01:00
Contributor
Copy Link

What?

I've gone through the code and replaced the following terms:

'blacklist' -> 'denylist'
'whitelist' -> 'allowlist'

Why?

See Issue#2 - it boils down to an attempt in reducing harmful and exclusionary language.
The Inclusive Naming org gives a good rationale for updating these words specifically.

How?

Ran a sed command to recursively find/replace within the code.

I then manually reviewed the changes, and re-aligned certain parts of code.

Testing?

I've successfully run go build (go-version: 1.20), which appears to run OK.

Anything Else?

This PR does introduce a functional change, the flag from -blacklist to -denylist.
The README.md and other files are already updated to reflect that, but details of this change may need adding to the release notes.

## What? I've gone through the code and replaced the following terms: 'blacklist' -> 'denylist' 'whitelist' -> 'allowlist' ## Why? See [Issue#2](https://git.brainbaking.com/wgroeneveld/go-jamming/issues/2) - it boils down to an attempt in reducing harmful and exclusionary language. The [Inclusive Naming org](https://inclusivenaming.org/word-lists/tier-1/whitelist/) gives a good rationale for updating these words specifically. ## How? Ran a `sed` command to recursively find/replace within the code. I then manually reviewed the changes, and re-aligned certain parts of code. ## Testing? I've successfully run `go build` (go-version: 1.20), which appears to run OK. ## Anything Else? This PR does introduce a functional change, the flag from `-blacklist` to `-denylist`. The `README.md` and other files are already updated to reflect that, but details of this change may need adding to the release notes.
JonathanStreet added 1 commit 2023-03-01 17:57:37 +01:00
wgroeneveld changed title from WIP: Inclusive language update (allowlist/denylist). to Inclusive language update (allowlist/denylist). 2023-03-03 16:17:36 +01:00
wgroeneveld commented 2023-03-03 16:17:55 +01:00
Owner
Copy Link

This looks great, thanks!

This looks great, thanks!
👍 1
wgroeneveld merged commit ab835c0457 into master 2023-03-03 16:18:02 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wgroeneveld/go-jamming#4
No description provided.
Delete Branch "JonathanStreet/go-jamming:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?