From 2360186d5a143bc4417c6996d8c276a40c5c8008 Mon Sep 17 00:00:00 2001 From: wgroeneveld Date: Mon, 8 Mar 2021 17:55:44 +0100 Subject: [PATCH] fix valid domain test for target, not source --- src/webmention/receive.js | 2 +- test/webmention/receive-validate.test.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/webmention/receive.js b/src/webmention/receive.js index cb2596a..8d360e8 100644 --- a/src/webmention/receive.js +++ b/src/webmention/receive.js @@ -39,7 +39,7 @@ function validate(request) { isValidUrl(request?.body?.source) && isValidUrl(request?.body?.target) && request?.body?.source !== request?.body?.target && - isValidDomain(request?.body?.source) + isValidDomain(request?.body?.target) } async function isValidTargetUrl(target) { diff --git a/test/webmention/receive-validate.test.js b/test/webmention/receive-validate.test.js index a6556ce..1e0a9e5 100644 --- a/test/webmention/receive-validate.test.js +++ b/test/webmention/receive-validate.test.js @@ -20,12 +20,12 @@ describe("webmention receiver validate tests", () => { expect(result).toBe(true) }) - test("is NOT valid if source is a valid url but not form valid domain", () => { + test("is NOT valid if target is a valid url but not form valid domain", () => { const result = validate({ type: "application/x-www-form-urlencoded", body: { - source: urlfrominvaliddomain, - target: validhttpsurl + "2" + source: validhttpsurl + "2", + target: urlfrominvaliddomain } })